feat: implement r+, r= and r- #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vohoanglong0107
force-pushed
the
feat-accept-pr
branch
from
0a33cb0 to
ea26761
Compare
Kobzol
reviewed
Jun 29, 2024
| tester.get_comment().await?, | ||
| format!( | ||
| "Commit pr-{}-sha has been approved by `{}`", | ||
| default_pr_number(), |
There was a problem hiding this comment.
I think it's find to hardcode these values here to make the test simpler. If we ever change them in the future, the test will just fail.
There was a problem hiding this comment.
Ah the reason I'm not hardcoding the values in was I didn't know where those values come from, and this was my attempt to explain the origin of those values for future me 😅
There was a problem hiding this comment.
That's not a bad reason! I hope we could make the default values so obvious that this wouldn't be needed though, and it would be immediately obvious from the test that 1 or default-user etc. is a special value :)
vohoanglong0107
force-pushed
the
feat-accept-pr
branch
from
9169d89 to
42056cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.